Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/251#issuecomment-38890757
  
    Hey I just looked at this. Why not just have `stop` call 
`waitUntilEmpty(infinity)` and be done with it? I don't see a big advantage of 
the current approach over that.
    
    I can only think of two differences. One is that in the current approach is 
slightly more efficient - but I don't think that matters for this use case. 
Another is that the current approach blocks the addition of new events after 
`stop` has been called. But I think it's fine to just say that the semantics of 
events triggered after a `stop` are undefined.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to