Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/251#discussion_r11087358
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala ---
@@ -72,6 +72,20 @@ class SparkListenerSuite extends FunSuite with
LocalSparkContext with ShouldMatc
}
}
+ test("bus.stop() waits for the event queue to completely drain") {
+ val sleepyListener = new SleepyListener(1000)
+ val bus = new LiveListenerBus
+ bus.addListener(sleepyListener)
+ (1 to 5).foreach { _ => bus.post(SparkListenerJobEnd(0, JobSucceeded))
}
+
+ bus.start()
+ // since the handler is just thread sleep, the queue should not drain
immediately
+ assert(!bus.waitUntilEmpty(0))
+ bus.stop()
+ // bus.stop() should wait until the event queue is drained, ensuring
no events are lost
+ assert(bus.waitUntilEmpty(0))
--- End diff --
I think it makes sense to expose something like `bus.isEmpty`. I find
`waitUntilEmpty` with a 0ms timeout a little confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
