HyukjinKwon commented on a change in pull request #28085:
[SPARK-29641][PYTHON][CORE] Stage Level Sched: Add python api's and tests
URL: https://github.com/apache/spark/pull/28085#discussion_r407334754
##########
File path:
core/src/main/scala/org/apache/spark/resource/ExecutorResourceRequests.scala
##########
@@ -38,6 +39,8 @@ private[spark] class ExecutorResourceRequests() extends
Serializable {
def requests: Map[String, ExecutorResourceRequest] =
_executorResources.asScala.toMap
+ def requestsJMap: JMap[String, ExecutorResourceRequest] = requests.asJava
Review comment:
If you target to support Java API from this class, it might be just best to
let `requests` return a Java map directly. In Scala side, it's pretty easily
able to use via using `asScala`. I think this is the usual approach in the case
base if I am not mistaken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
