HyukjinKwon commented on a change in pull request #28085: [SPARK-29641][PYTHON][CORE] Stage Level Sched: Add python api's and tests URL: https://github.com/apache/spark/pull/28085#discussion_r408188570
########## File path: python/pyspark/resource/executorresourcerequest.py ########## @@ -0,0 +1,73 @@ +# Review comment: I would have not commented if this was one class per one file. My point is to group the classes into one or several files. You can group it as you want but one class per on file seems not so "Pythonic" as I pointed out with the links and examples. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
