HyukjinKwon commented on a change in pull request #28085: [SPARK-29641][PYTHON][CORE] Stage Level Sched: Add python api's and tests URL: https://github.com/apache/spark/pull/28085#discussion_r407799492
########## File path: python/pyspark/resource/executorresourcerequest.py ########## @@ -0,0 +1,73 @@ +# Review comment: Yes, I noticed some files are like that but the classes here look pretty small. There are opposite examples such as `pyspark/sql/readwriter.py`, `pyspark/sql/streaming.py`, `pyspark/status.py`, `pyspark/sql/window.py`, `pyspark/sql/utils.py`, `pyspark/sql/udf.py` and `pyspark/sql/types.py`. I admit there's no strict rule on this and I have no point of the official documentation to follow. Just in practice, it's usual to group several relevant classes, e.g.) https://stackoverflow.com/questions/106896/how-many-classes-should-i-put-in-one-file. Python module is more like Java's package instead of class file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
