HyukjinKwon commented on a change in pull request #28085:
[SPARK-29641][PYTHON][CORE] Stage Level Sched: Add python api's and tests
URL: https://github.com/apache/spark/pull/28085#discussion_r408197518
##########
File path:
core/src/main/scala/org/apache/spark/resource/ExecutorResourceRequests.scala
##########
@@ -38,6 +39,8 @@ private[spark] class ExecutorResourceRequests() extends
Serializable {
def requests: Map[String, ExecutorResourceRequest] =
_executorResources.asScala.toMap
+ def requestsJMap: JMap[String, ExecutorResourceRequest] = requests.asJava
Review comment:
I was not so against it because I took it as just one or several exceptions.
If this is going to be a pattern, I think it is a problem. Why not have one
function legitimate for both Scala and Java that gives you a consistent API
usage. Other "java specific" have the same names and most of then are just
overloading. See `functions.scala` as an example.
I would like to run this separately though rather then setting up the policy
here which might be slightly off topic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
