Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5085#issuecomment-84003610
Going "off road" is up to the adventurous consumer. I think I'd produce a
build with standard `make-distribution.sh` tools or the like, which should dump
out a binary with `hadoop` in the name anyway, and link to that. I don't think
I would modify scripts anyway.
That said, yeah, why not just look for `spark-assembly.*\.jar`? I don't see
why `hadoop` is so important there. That's a plausible way to identify _the_
intended assembly JAR. Is there an outside risk that somebody is running with
two `spark-assembly` files in the same dir, one of which has `hadoop` in the
name, and this breaks that?
My hunch is there's a reason for the separate JAR, like decoupling the
launcher from the launchee as was done previously with the scripts.
Anyway, net-net at the moment I'd support loosening the regex but it is a
sort of theoretical problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
