xkrogen commented on a change in pull request #28874:
URL: https://github.com/apache/spark/pull/28874#discussion_r443831706
##########
File path: core/src/test/scala/org/apache/spark/ui/UISeleniumSuite.scala
##########
@@ -48,24 +48,24 @@ import org.apache.spark.util.CallSite
private[spark] class SparkUICssErrorHandler extends DefaultCssErrorHandler {
- private val cssWhiteList = List("bootstrap.min.css",
"vis-timeline-graph2d.min.css")
+ private val cssExcludeList = List("bootstrap.min.css",
"vis-timeline-graph2d.min.css")
Review comment:
I think `exclude` is more appropriate here as we are excluding errors
from these files from the logs. Nothing about these files is being allowed. See
the original PR #5983 for the intent.
I think, rather than looking at the previous name "whitelist" and trying to
come up with something that matches that description, we should be looking at
the variable's use/purpose and asking "what is the ideal name for this
variable?". In this case, though it was referred to as a whitelist, it was
really an exclude-list or an ignored list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
