xkrogen commented on a change in pull request #28874:
URL: https://github.com/apache/spark/pull/28874#discussion_r445023392
##########
File path:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
##########
@@ -181,23 +181,23 @@ private[history] class FsHistoryProvider(conf: SparkConf,
clock: Clock)
processing.remove(path.getName)
}
- private val blacklist = new ConcurrentHashMap[String, Long]
+ private val ignoreList = new ConcurrentHashMap[String, Long]
// Visible for testing
- private[history] def isBlacklisted(path: Path): Boolean = {
- blacklist.containsKey(path.getName)
+ private[history] def isIgnored(path: Path): Boolean = {
+ ignoreList.containsKey(path.getName)
}
- private def blacklist(path: Path): Unit = {
- blacklist.put(path.getName, clock.getTimeMillis())
+ private def ignore(path: Path): Unit = {
+ ignoreList.put(path.getName, clock.getTimeMillis())
}
/**
- * Removes expired entries in the blacklist, according to the provided
`expireTimeInSeconds`.
+ * Removes expired entries in the ignoreList, according to the provided
`expireTimeInSeconds`.
*/
- private def clearBlacklist(expireTimeInSeconds: Long): Unit = {
+ private def clearIgnoreList(expireTimeInSeconds: Long): Unit = {
val expiredThreshold = clock.getTimeMillis() - expireTimeInSeconds * 1000
- blacklist.asScala.retain((_, creationTime) => creationTime >=
expiredThreshold)
+ ignoreList.asScala.retain((_, creationTime) => creationTime >=
expiredThreshold)
Review comment:
I think the discussion on SPARK-32037 won't necessarily apply here --
the discussion there, IMO, isn't what the one best term to replace "blacklist"
is, but rather what the best term to describe the "blacklisting feature" is.
The best term to replace "blacklist" in each of these scenarios will vary,
independent of that discussion.
For this specific one, I agree that `ignoreList` is not great. I struggled
with this one. What do you think of `inaccessibleList`? I think this is the
most descriptive. `blockList` IMO doesn't really describe what is happening.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
