xkrogen commented on a change in pull request #28874:
URL: https://github.com/apache/spark/pull/28874#discussion_r445140110
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQueryFileTest.scala
##########
@@ -45,25 +45,34 @@ abstract class HiveQueryFileTest extends HiveComparisonTest
{
runOnlyDirectories.nonEmpty ||
skipDirectories.nonEmpty
- val whiteListProperty: String = "spark.hive.whitelist"
- // Allow the whiteList to be overridden by a system property
- val realWhiteList: Seq[String] =
-
Option(System.getProperty(whiteListProperty)).map(_.split(",").toSeq).getOrElse(whiteList)
+ val deprecatedIncludeListProperty: String = "spark.hive.whitelist"
+ val includeListProperty: String = "spark.hive.includelist"
Review comment:
OK, will leave the deprecation for now. Thanks for the discussion!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
