xkrogen commented on a change in pull request #28874:
URL: https://github.com/apache/spark/pull/28874#discussion_r445024306
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQueryFileTest.scala
##########
@@ -45,25 +45,34 @@ abstract class HiveQueryFileTest extends HiveComparisonTest
{
runOnlyDirectories.nonEmpty ||
skipDirectories.nonEmpty
- val whiteListProperty: String = "spark.hive.whitelist"
- // Allow the whiteList to be overridden by a system property
- val realWhiteList: Seq[String] =
-
Option(System.getProperty(whiteListProperty)).map(_.split(",").toSeq).getOrElse(whiteList)
+ val deprecatedIncludeListProperty: String = "spark.hive.whitelist"
+ val includeListProperty: String = "spark.hive.includelist"
Review comment:
I believe it would be a user-provided string. I was going back and forth
on whether or not maintaining it as a deprecated property is necessary. From my
reading, this is a developer-only property that would be applied during a
testing/development cycle. I tried to be as cautious as possible to maintain
compatibility to any contention, but in this case it seems it may be
unnecessary. I would love to hear your thoughts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
