Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5350#discussion_r27761570
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvaluationSuite.scala
---
@@ -59,6 +60,10 @@ class ExpressionEvaluationBaseSuite extends FunSuite {
class ExpressionEvaluationSuite extends ExpressionEvaluationBaseSuite {
+ def create_row(values: Any*): Row = {
+ new GenericRow(values.map(ScalaReflection.convertToCatalyst).toArray)
--- End diff --
I see. Perhaps that is actually the way that we should handle inbound
conversions for data coming from users, instead of doing it on inbound RDDs.
If we make `Row.apply` do the conversion then we always have converted data
from users. Low level APIs construct rows or mutable rows directly to avoid
the conversion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
