cloud-fan commented on a change in pull request #29952:
URL: https://github.com/apache/spark/pull/29952#discussion_r501187450
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCTableCatalog.scala
##########
@@ -70,7 +70,9 @@ class JDBCTableCatalog extends TableCatalog with Logging {
checkNamespace(ident.namespace())
val writeOptions = new JdbcOptionsInWrite(
options.parameters + (JDBCOptions.JDBC_TABLE_NAME ->
getTableName(ident)))
- withConnection(JdbcUtils.tableExists(_, writeOptions))
+ classifyException(s"Failed table existence check: $ident") {
Review comment:
shall we be consistent and always put `classifyException` inside
`withConnection`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
