cloud-fan commented on a change in pull request #29952:
URL: https://github.com/apache/spark/pull/29952#discussion_r501191826
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -297,6 +308,7 @@ object JdbcDialects {
registerDialect(DerbyDialect)
registerDialect(OracleDialect)
registerDialect(TeradataDialect)
+ registerDialect(H2Dialect)
Review comment:
since we already have a `testH2Dialect`, how about we update
`testH2Dialect` to implement `classifyException`, and use it in
`JDBCTableCatalogSuite`? Then we don't need to have an official `H2Dialect`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
