MaxGekk commented on a change in pull request #29952:
URL: https://github.com/apache/spark/pull/29952#discussion_r501220067
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -297,6 +308,7 @@ object JdbcDialects {
registerDialect(DerbyDialect)
registerDialect(OracleDialect)
registerDialect(TeradataDialect)
+ registerDialect(H2Dialect)
Review comment:
If you look at `testH2Dialect`, it has test specific settings. Why
should we have the settings in `JDBCTableCatalogSuite`?
> Then we don't need to have an official `H2Dialect`.
What is the problem to have built-in H2Dialect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
