MaxGekk commented on a change in pull request #29952:
URL: https://github.com/apache/spark/pull/29952#discussion_r501239752
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -297,6 +308,7 @@ object JdbcDialects {
registerDialect(DerbyDialect)
registerDialect(OracleDialect)
registerDialect(TeradataDialect)
+ registerDialect(H2Dialect)
Review comment:
Probably, not related to this. If we don't want to support H2 officially
as a dialect, why do we test it so broadly in Spark.?Maybe it makes sense to
switch all internal Spark tests to Derby?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
