HeartSaVioR commented on a change in pull request #30563:
URL: https://github.com/apache/spark/pull/30563#discussion_r533852656
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
##########
@@ -59,7 +59,7 @@ abstract class StreamingJoinSuite
(input, df)
}
- protected def setupWindowedJoin(joinType: String)
+ protected def setupJoin(joinType: String)
Review comment:
Probably I wasn't clear. This is a windowed join (though I also don't
know whether this is an official representation) because we join two stream via
"time window". Some tests don't join with time window and still have `windowed`
in their name - that's what I meant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
