HeartSaVioR commented on a change in pull request #30563:
URL: https://github.com/apache/spark/pull/30563#discussion_r533856029
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
##########
@@ -76,7 +76,7 @@ abstract class StreamingJoinSuite
(input1, input2, select)
}
- protected def setupWindowedJoinWithLeftCondition(joinType: String)
+ protected def setupJoinWithLeftCondition(joinType: String)
Review comment:
Here as well, and at least also `setupJoinWithRightCondition`. Please
revisit your changes to apply my comment instead of fixing only where I pointed
out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
