HyukjinKwon commented on a change in pull request #30563:
URL: https://github.com/apache/spark/pull/30563#discussion_r533863692
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
##########
@@ -136,7 +136,7 @@ abstract class StreamingJoinSuite
(leftInput, rightInput, select)
}
- protected def setupWindowedJoinWithRangeCondition(joinType: String)
+ protected def setupJoinWithRangeCondition(joinType: String)
Review comment:
Fixing nits alone in a PR is not encouraged in general. They can be
fixed together when you touch this codes or review other PRs to fix. It's okay
since the PR is already open but let's avoid next time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
