c21 commented on a change in pull request #30563:
URL: https://github.com/apache/spark/pull/30563#discussion_r533866059
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingJoinSuite.scala
##########
@@ -136,7 +136,7 @@ abstract class StreamingJoinSuite
(leftInput, rightInput, select)
}
- protected def setupWindowedJoinWithRangeCondition(joinType: String)
+ protected def setupJoinWithRangeCondition(joinType: String)
Review comment:
@HyukjinKwon - thanks for pointing it out. Just for my own understanding
to better follow next time, is `[MINOR][FOLLOWUP]` PR discouraged, or
`[MINOR][FOLLOWUP]` nits (renaming, fixing code style, etc) PR discouraged?
And what's could be a MINOR PR besides nits (maybe refactoring)? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
