rdblue commented on pull request #31451: URL: https://github.com/apache/spark/pull/31451#issuecomment-772851822
I think that this could use some tests. It would be easier to add tests if it were split to add the interfaces, a batch implementation (with tests), and a stream implementation (with stream tests). Thanks for working on this, @viirya! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
