Ngone51 commented on a change in pull request #31451:
URL: https://github.com/apache/spark/pull/31451#discussion_r570234278



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/BatchScanExec.scala
##########
@@ -44,8 +44,19 @@ case class BatchScanExec(
 
   override lazy val readerFactory: PartitionReaderFactory = 
batch.createReaderFactory()
 
+  /**
+   * The callback function which is called when the output iterator of input 
RDD is consumed
+   * completely.
+   */
+  private def onOutputCompletion(reader: PartitionReader[_]) = {

Review comment:
       Do we have the plan to do other things on completion? Otherwise, I'd 
like to suggest naming `collectMetericsOnCompletion` for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to