viirya commented on a change in pull request #31451:
URL: https://github.com/apache/spark/pull/31451#discussion_r569874733
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2ScanExecBase.scala
##########
@@ -32,8 +32,13 @@ import org.apache.spark.util.Utils
trait DataSourceV2ScanExecBase extends LeafExecNode {
- override lazy val metrics = Map(
- "numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"))
+ override lazy val metrics = {
Review comment:
I looked at a few V2 write nodes, but seems we don't have any SQL
metrics there. I guess we don't provide metrics for writes generally now?
If there is interest to see metrics in writes, I think it is okay to work on
it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
