Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5820#discussion_r29610747
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -81,15 +82,22 @@ abstract class PipelineStage extends Serializable with
Logging {
@AlphaComponent
class Pipeline extends Estimator[PipelineModel] {
- /** param for pipeline stages */
+ /**
+ * param for pipeline stages
+ * @group param
+ */
val stages: Param[Array[PipelineStage]] = new Param(this, "stages",
"stages of the pipeline")
+
+ /** @group setParam */
def setStages(value: Array[PipelineStage]): this.type = { set(stages,
value); this }
- def getStages: Array[PipelineStage] = getOrDefault(stages)
- override def validate(paramMap: ParamMap): Unit = {
+ /** @group getParam */
+ def getStages: Array[PipelineStage] = $(stages).clone()
--- End diff --
It might be worth putting a comment here about why stages need to be cloned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
