Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5820#discussion_r29610787
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/param/params.scala ---
    @@ -269,7 +271,11 @@ trait Params extends Identifiable with Serializable {
        * [[Param.validate()]].  This method does not handle input/output 
column parameters;
        * those are checked during schema validation.
        */
    -  def validate(): Unit = validate(ParamMap.empty)
    +  def validateParams(): Unit = {
    --- End diff --
    
    This implementation should not be necessary.  per-param validate is called 
whenever a ParamPair is constructed (and Params can only be specified via 
ParamPairs)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to