Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5820#discussion_r29610753
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -69,17 +68,17 @@ class LogisticRegression
// Train model
val lr = new LogisticRegressionWithLBFGS()
- .setIntercept(paramMap(fitIntercept))
+ .setIntercept($(fitIntercept))
lr.optimizer
- .setRegParam(paramMap(regParam))
- .setNumIterations(paramMap(maxIter))
+ .setRegParam($(regParam))
+ .setNumIterations($(maxIter))
val oldModel = lr.run(oldDataset)
- val lrm = new LogisticRegressionModel(this, paramMap,
oldModel.weights, oldModel.intercept)
+ val lrm = new LogisticRegressionModel(this, oldModel.weights,
oldModel.intercept)
if (handlePersistence) {
oldDataset.unpersist()
}
- lrm
+ copyValues(lrm)
--- End diff --
Not needed (done in Predictor.fit)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
