Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5820#discussion_r29610762
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -152,19 +152,17 @@ private[recommendation] trait ALSParams extends
Params with HasMaxIter with HasR
/**
* Validates and transforms the input schema.
* @param schema input schema
- * @param paramMap extra params
* @return output schema
*/
- protected def validateAndTransformSchema(schema: StructType, paramMap:
ParamMap): StructType = {
- val map = extractParamMap(paramMap)
- assert(schema(map(userCol)).dataType == IntegerType)
- assert(schema(map(itemCol)).dataType== IntegerType)
- val ratingType = schema(map(ratingCol)).dataType
- assert(ratingType == FloatType || ratingType == DoubleType)
- val predictionColName = map(predictionCol)
- assert(!schema.fieldNames.contains(predictionColName),
+ protected def validateAndTransformSchema(schema: StructType): StructType
= {
+ require(schema($(userCol)).dataType == IntegerType)
+ require(schema($(itemCol)).dataType== IntegerType)
--- End diff --
space before ==
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
