huaxingao commented on a change in pull request #33822:
URL: https://github.com/apache/spark/pull/33822#discussion_r695845556
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
##########
@@ -278,12 +278,18 @@ private[sql] case class JDBCRelation(
}
override def buildScan(requiredColumns: Array[String], filters:
Array[Filter]): RDD[Row] = {
+ // When pushDownPredicate is false, all Filters that need to be pushed
down should be ignored
+ val pushedFilters = if (jdbcOptions.pushDownPredicate) {
+ filters
+ } else {
+ Array.empty[Filter]
+ }
Review comment:
If `pushDownPredicate` is false, the unhandledFilters are set to all the
filters here
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala#L276.
Seems to me that the unhandledFilters shouldn't be pushed down to JDBC at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
