cloud-fan commented on a change in pull request #33822:
URL: https://github.com/apache/spark/pull/33822#discussion_r695853027
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
##########
@@ -278,12 +278,18 @@ private[sql] case class JDBCRelation(
}
override def buildScan(requiredColumns: Array[String], filters:
Array[Filter]): RDD[Row] = {
+ // When pushDownPredicate is false, all Filters that need to be pushed
down should be ignored
+ val pushedFilters = if (jdbcOptions.pushDownPredicate) {
+ filters
+ } else {
+ Array.empty[Filter]
+ }
Review comment:
Yea, it's a bug since day 1: https://github.com/apache/spark/pull/21875
I think we should update the tested add at that time and check the real
pushed filters in JDBC source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
