rdblue commented on a change in pull request #34497:
URL: https://github.com/apache/spark/pull/34497#discussion_r749623829
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -598,6 +598,13 @@ fromClause
: FROM relation (',' relation)* lateralView* pivotClause?
;
+temporalClause
+ : VERSION AS OF version=INTEGER_VALUE
+ | FOR SYSTEM_VERSION AS OF version=INTEGER_VALUE
Review comment:
I agree. Shouldn't all of these be strings or even more generic so that
the user can pass whatever is a version in a particular storage layer? HBase
would use a long, but versions could easily be a UUID or some other type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
