rdblue commented on a change in pull request #34497:
URL: https://github.com/apache/spark/pull/34497#discussion_r749628312
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -598,6 +598,13 @@ fromClause
: FROM relation (',' relation)* lateralView* pivotClause?
;
+temporalClause
+ : VERSION AS OF version=INTEGER_VALUE
Review comment:
Wouldn't it be easier to combine the rules?
```
: FOR? (SYSTEM_VERSION | VERSION) AS OF version=STRING
```
Otherwise, you have to remember that `SYSTEM_VERSION` requires `FOR` and
`VERSION` is incompatible with it. That's a poor user experience because `FOR
VERSION AS OF` would result in a parse error. Probably best to make `FOR`
optional in both cases. Same for `TIMESTAMP` and `SYSTEM_TIME`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
