rdblue commented on a change in pull request #34497:
URL: https://github.com/apache/spark/pull/34497#discussion_r749779617
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -598,6 +598,13 @@ fromClause
: FROM relation (',' relation)* lateralView* pivotClause?
;
+temporalClause
+ : VERSION AS OF version=INTEGER_VALUE
+ | FOR SYSTEM_VERSION AS OF version=INTEGER_VALUE
Review comment:
I think so. Not everything can be expressed easily as an identifier. For
example, if you wanted to specify a version string that is a UUID, the most
natural way to do that would be to quote it: `VERSION AS OF
'8a22ccf1-9bb6-4a39-99ca-13afad959fe2'`. We could quote with backticks to use
an identifier instead, but if we can support either quote style then that
reduces user mistakes.
I'd be okay dropping support for identifier, but I think we should
definitely support strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
