rdblue commented on a change in pull request #34497:
URL: https://github.com/apache/spark/pull/34497#discussion_r750435003
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -599,6 +599,11 @@ fromClause
: FROM relation (',' relation)* lateralView* pivotClause?
;
+temporalClause
+ : FOR? (SYSTEM_VERSION | VERSION) AS OF version=(INTEGER_VALUE | STRING)
Review comment:
@huaxingao, I don't this change is a good idea. This is only going to
cause problems when a user attempts to use `FOR VERSION AS OF` or
`SYSTEM_VERSION AS OF`. There's no value in failing queries like that. If we're
going to support `VERSION` in place of `SYSTEM_VERSION`, then we should be
careful to avoid mistakes like this that result in parse errors and unhappy
users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
