Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-101067933
The QA phase is not a reason to rush this patch in half finished. This
isn't a regression and there is a trivial workaround (use consistent
capitalization).
If we are going to add `ExpressionMap` and `ExpressionSet`, they should be
complete and have tests. It is also pretty weird for a `Set` to not return the
same elements that are put into it. Also, I don't think the current method of
normalization is sufficient. It will fail if other unimportant properties
(such as scope) differ.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
