Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-101089451
If you break equality you will break the `transform` function.
You can't stop people from using expression equality incorrectly, but you
also can't stop them from doing `a1.name == a2.name` and it's equally invalid
(and happened in the code in quite a few places before we added `AttributeSet`.
I'm not sure there is a way to make the compiler understand what type of
equality you are looking for. I think the best solution is awareness of the
sharp edges amongst people reviewing code and nice helper classes for dealing
the the various types of equality that we care about.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
