Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/5798#issuecomment-101109983
Thank you @marmbrus for the explanation. I was thinking if there is a
simple way to make the `Expression` more like a general class, which can be
used with common collections like `Map.get`, `Set.contains` etc. We can keep it
for the future improvement.
For this PR, I am not sure if we really need a real `Map` or `Seq` as we
did for `AttributeMap` and `AttributeSet`, the `Attribute` are used more widely
in `ColumnPruning`, `ExtractEquiJoinKey`, `Expression.references` etc., but
`ExpressionMap/Set` is not the case. That's why put very limited methods there.
I can add more methods/tests if you feel we should do it in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
