Github user chenghao-intel commented on the pull request:

    https://github.com/apache/spark/pull/5798#issuecomment-101081212
  
    Will it be simpler if we refactor the `AttributeReference` that not to 
compare the `nullable`, `dataType` or `name`, but `exprId`? If in that case, 
then we might remove both `AttributeSet`, `AttributeMap` etc.
    
    Says:
    ```scala
    case class AttributeReference(exprId:String=ExprId)(name: String ...)
    ```
    I don't think we can stop people to write code like:
    ···
        val exprs: Seq[Expression] = ...
        exprs.toSet.contains(otherExpression)
    ···


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to