cloud-fan commented on a change in pull request #35768:
URL: https://github.com/apache/spark/pull/35768#discussion_r828027986
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
##########
@@ -270,36 +271,36 @@ private[sql] case class JDBCRelation(
override val needConversion: Boolean = false
- // Check if JDBCRDD.compileFilter can accept input filters
+ // Check if JdbcDialect can compile input filters
override def unhandledFilters(filters: Array[Filter]): Array[Filter] = {
if (jdbcOptions.pushDownPredicate) {
- filters.filter(JDBCRDD.compileFilter(_,
JdbcDialects.get(jdbcOptions.url)).isEmpty)
+ filters.filter(f =>
JdbcDialects.get(jdbcOptions.url).compileExpression(f.toV2).isEmpty)
Review comment:
nit: we should call `JdbcDialects.get` only once. Let's do it before
calling `filters.filter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
