beliefer commented on code in PR #35975:
URL: https://github.com/apache/spark/pull/35975#discussion_r847897667
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala:
##########
@@ -407,10 +407,31 @@ trait CheckAnalysis extends PredicateHelper with
LookupCatalog {
case GlobalLimit(limitExpr, _) => checkLimitLikeClause("limit",
limitExpr)
- case LocalLimit(limitExpr, _) => checkLimitLikeClause("limit",
limitExpr)
+// case LocalLimit(limitExpr, _) => checkLimitLikeClause("limit",
limitExpr)
+ case LocalLimit(limitExpr, child) =>
+ checkLimitLikeClause("limit", limitExpr)
+ child match {
+ case Offset(offsetExpr, _) =>
+ val limit = limitExpr.eval().asInstanceOf[Int]
+ val offset = offsetExpr.eval().asInstanceOf[Int]
+ if (Int.MaxValue - limit < offset) {
+ failAnalysis(
+ s"""The sum of limit and offset must not be greater than
Int.MaxValue,
+ | but found limit = $limit, offset =
$offset.""".stripMargin)
+ }
+ case _ =>
+ }
+
+ case Offset(offsetExpr, _) => checkLimitLikeClause("offset",
offsetExpr)
case Tail(limitExpr, _) => checkLimitLikeClause("tail", limitExpr)
+ case o if !o.isInstanceOf[GlobalLimit] && !o.isInstanceOf[LocalLimit]
+ && o.children.exists(_.isInstanceOf[Offset]) =>
+ failAnalysis(
+ s"""Only the OFFSET clause is allowed in the LIMIT clause, but
the OFFSET
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
