beliefer commented on code in PR #35975:
URL: https://github.com/apache/spark/pull/35975#discussion_r847934315
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -1145,6 +1145,23 @@ case class Expand(
copy(child = newChild)
}
+/**
+ * A logical offset, which may removing a specified number of rows from the
beginning of the
+ * output of child logical plan.
Review Comment:
1. is good but have described in `CheckAnalysis.scala`.
2. `Offset` is a logical node. The information you mentioned is a physical
behavior.
3. The boundary conditions is also mentioned in `CheckAnalysis.scala`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
