beliefer commented on code in PR #35975:
URL: https://github.com/apache/spark/pull/35975#discussion_r847936855
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -1145,6 +1145,23 @@ case class Expand(
copy(child = newChild)
}
+/**
+ * A logical offset, which may removing a specified number of rows from the
beginning of the
+ * output of child logical plan.
+ */
+case class Offset(offsetExpr: Expression, child: LogicalPlan) extends
OrderPreservingUnaryNode {
+ override def output: Seq[Attribute] = child.output
+ override def maxRows: Option[Long] = {
+ import scala.math.max
+ offsetExpr match {
+ case IntegerLiteral(offset) => child.maxRows.map { x => max(x - offset,
0) }
+ case _ => None
Review Comment:
Yes. But this is good for Scala's pattern match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
