beliefer commented on code in PR #35975:
URL: https://github.com/apache/spark/pull/35975#discussion_r847900161


##########
sql/core/src/test/resources/sql-tests/inputs/postgreSQL/limit.sql:
##########
@@ -12,25 +12,24 @@ SELECT '' AS five, unique1, unique2, stringu1
 SELECT '' AS two, unique1, unique2, stringu1
                FROM onek WHERE unique1 > 60 AND unique1 < 63
                ORDER BY unique1 LIMIT 5;
--- [SPARK-28330] ANSI SQL: Top-level <result offset clause> in <query 
expression>
--- SELECT '' AS three, unique1, unique2, stringu1
---             FROM onek WHERE unique1 > 100
---             ORDER BY unique1 LIMIT 3 OFFSET 20;
--- SELECT '' AS zero, unique1, unique2, stringu1
---             FROM onek WHERE unique1 < 50
---             ORDER BY unique1 DESC LIMIT 8 OFFSET 99;
--- SELECT '' AS eleven, unique1, unique2, stringu1
---             FROM onek WHERE unique1 < 50
---             ORDER BY unique1 DESC LIMIT 20 OFFSET 39;
+SELECT '' AS three, unique1, unique2, stringu1
+               FROM onek WHERE unique1 > 100
+               ORDER BY unique1 LIMIT 3 OFFSET 20;
+ SELECT '' AS zero, unique1, unique2, stringu1
+               FROM onek WHERE unique1 < 50
+               ORDER BY unique1 DESC LIMIT 8 OFFSET 99;
+ SELECT '' AS eleven, unique1, unique2, stringu1
+               FROM onek WHERE unique1 < 50
+               ORDER BY unique1 DESC LIMIT 20 OFFSET 39;
 -- SELECT '' AS ten, unique1, unique2, stringu1

Review Comment:
   According the discussion offline between @cloud-fan and me. we not plan to 
support offset without limit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to