grundprinzip commented on code in PR #38157:
URL: https://github.com/apache/spark/pull/38157#discussion_r990760884
##########
connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala:
##########
@@ -46,6 +51,37 @@ class SparkConnectProtoSuite extends PlanTest with
SparkConnectPlanTest {
comparePlans(connectPlan.analyze, sparkPlan.analyze, false)
}
+ test("Basic joins with different join types") {
+ val connectPlan = {
Review Comment:
can you add a test-case for unspecified as well to see that we catch the
error?
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -22,10 +22,10 @@ import scala.collection.JavaConverters._
import org.apache.spark.annotation.{Since, Unstable}
import org.apache.spark.connect.proto
import org.apache.spark.sql.SparkSession
-import org.apache.spark.sql.catalyst.{expressions, plans}
import org.apache.spark.sql.catalyst.analysis.{UnresolvedAlias,
UnresolvedAttribute, UnresolvedFunction, UnresolvedRelation, UnresolvedStar}
+import org.apache.spark.sql.catalyst.expressions
import org.apache.spark.sql.catalyst.expressions.{Attribute,
AttributeReference, Expression}
-import org.apache.spark.sql.catalyst.plans.logical
Review Comment:
can you please keep the package import? This makes it easier to read where
the specific classes come from in particular when they have similar names.
So it's easier to ready seeing `logical.JoinType` and `proto.JoinType` for
example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
