amaliujia commented on code in PR #38157:
URL: https://github.com/apache/spark/pull/38157#discussion_r990963408
##########
connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala:
##########
@@ -46,6 +51,37 @@ class SparkConnectProtoSuite extends PlanTest with
SparkConnectPlanTest {
comparePlans(connectPlan.analyze, sparkPlan.analyze, false)
}
+ test("Basic joins with different join types") {
+ val connectPlan = {
Review Comment:
I discussed with @cloud-fan and we decided to remove both `JoinType.CROSS`
and `JoinType.Unspecified`.
Proto is our API. We should make the proto itself less ambiguous. For
example any proto submitted to the server should not contain a
`JoinType.Unspecified`. It is either set a join type with explicit semantic
(inner, left outer, etc.) or not set, which Spark by default treats as inner
join.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
