grundprinzip commented on code in PR #38157:
URL: https://github.com/apache/spark/pull/38157#discussion_r990978234
##########
connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala:
##########
@@ -46,6 +51,37 @@ class SparkConnectProtoSuite extends PlanTest with
SparkConnectPlanTest {
comparePlans(connectPlan.analyze, sparkPlan.analyze, false)
}
+ test("Basic joins with different join types") {
+ val connectPlan = {
Review Comment:
There are two layers of this discussion one on the proto infra level and one
on the API level. I'm fine with the API level decision.
My point referred to the recommendations when using protos:
- All enums must have an unspecified element due to the different ways
languages deal with default construction (cf
https://developers.google.com/protocol-buffers/docs/style#enums)
- There is no required field, all elements are always optional in proto3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
