grundprinzip commented on code in PR #38157:
URL: https://github.com/apache/spark/pull/38157#discussion_r990971428
##########
connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala:
##########
@@ -46,6 +51,37 @@ class SparkConnectProtoSuite extends PlanTest with
SparkConnectPlanTest {
comparePlans(connectPlan.analyze, sparkPlan.analyze, false)
}
+ test("Basic joins with different join types") {
+ val connectPlan = {
Review Comment:
The reason for unspecified is not the proto contract but the language
behavior for different auto generated targets. To avoid issues with defaults,
the recommendation in the typical proto style guides is to always have the
first element of an enum be unspecified.
Cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
