hvanhovell commented on code in PR #38193:
URL: https://github.com/apache/spark/pull/38193#discussion_r992254515
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -31,7 +31,7 @@ option java_package = "org.apache.spark.connect.proto";
message Relation {
RelationCommon common = 1;
oneof rel_type {
- Read read = 2;
+ UnresolvedRelation unresolved_relation = 2;
Review Comment:
I am not sure I follow why we need to bifurcate into different types of
reads in the proto. The whole point of using parsed plans is to have a high
level (non-ambiguous) description of the operation, not an implementation, the
latter is for Spark to figure out. We just need to describe whatever it takes
what is needed to read the data. If it is a table scan then it is easy, you
only need a name, otherwise you may have to add a bit more information.
BTW nitpicking on naming. Operations should almost always have a verb as its
name (scan, project, filter, aggregate, generate, ...) if it does not, you
probably should rethink the name. `UNRESOLVED RELATION` is the thing you want
to scan, and not the operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
