grundprinzip commented on code in PR #38193:
URL: https://github.com/apache/spark/pull/38193#discussion_r992522700
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -60,16 +60,9 @@ message SQL {
string query = 1;
}
-// Relation that reads from a file / table or other data source. Does not have
additional
-// inputs.
-message Read {
- oneof read_type {
- NamedTable named_table = 1;
Review Comment:
The benefits of not flattening is about intent. We're defining an intent for
"Read"ing data using different alternatives. To a certain degree it's kind of
like polymorphism :)
Personally, I prefer the hierarchy because it makes it clear how this should
be consumed from an API perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
