grundprinzip commented on code in PR #38193:
URL: https://github.com/apache/spark/pull/38193#discussion_r992464590
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -31,7 +31,7 @@ option java_package = "org.apache.spark.connect.proto";
message Relation {
RelationCommon common = 1;
oneof rel_type {
- Read read = 2;
+ UnresolvedRelation unresolved_relation = 2;
Review Comment:
Maybe we're getting closer to it. Yes, proto has proper Union type support.
So what the `Read` relation should look like is the following:
```
message Read {
oneof read_type {
UnresolvedRelation unresolved_relation = 1;
UnresolvedDataSource unresolved_data_source =2;
}
message UnresolvedRelation {
}
message UnresolvedDataSource {
}
}
```
The generated code has the right behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
