cloud-fan commented on code in PR #38193:
URL: https://github.com/apache/spark/pull/38193#discussion_r992475710
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -60,16 +60,9 @@ message SQL {
string query = 1;
}
-// Relation that reads from a file / table or other data source. Does not have
additional
-// inputs.
-message Read {
- oneof read_type {
- NamedTable named_table = 1;
Review Comment:
I see, yea we can add a new `DataSource` type here, in addition to the
`NamedTable`. This seems like we give them a parent class `Read`. Any benefits
of doing so compared to just flattening it? Please bear with me as I'm not very
familiar with protobuf...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
